June 30, 2009 Pokersource
Commit by loic :: r5987 /tags/poker_network_1_7_5_1/poker-network/:poker_network_1_7_5_1poker_network_1_7_5_1
June 30, 2009 09:14 PM
Commit by loic :: r5985 /tags/poker_network_1_7_5_1/:invalid poker_network_1_7_5_1invalid poker_network_1_7_5_1
June 30, 2009 09:14 PM
Commit by loic :: r5986 /tags/poker_network_1_7_5_1/:poker_network_1_7_5_1poker_network_1_7_5_1
June 30, 2009 09:14 PM
Commit by loic :: r5984 /trunk/poker-network/ChangeLog:*** empty log message ****** empty log message ***
June 30, 2009 07:47 PM
Commit by loic :: r5983 /trunk/poker-network/ (2 files in 2 dirs):https://gna.org/bugs/index.php?13821https://gna.org/bugs/index.php?13821 In pokerservice.py:spawnTourneyInCore,...
In pokerservice.py:spawnTourneyInCore, instead of setting satellite_of from the serial in the database, it is first translated from a tourneys_schedule.serial into a tourneys.serial. A number of checks can be made at this time and if something fails (such as the tourney not being in registering state), an error message is printed in the logs and the serial 0 is returned (which means this tournament is no longer considered a satellite).
June 30, 2009 07:43 PMJune 28, 2009 Pokersource
Commit by bkuhn :: r5982 /trunk/poker-network/ (4 files in 3 dirs):Merged table-picker-bug-13789 into trunk. TablePicker() now returnsMerged table-picker-bug-13789 into trunk. TablePicker() now returns fullest...
fullest table w/ seat that matches given criteria, which closed bug#13789.
This was implemented by simply adding an ORDER BY on listTables() query to
force the tables with the most players to be seen first by the selection
function, getTableBestByCriteria() which already returns when it finds the
first table that isn't full and the player has enough money to buy in for.
Loic raised concern about doing an ORDER BY serial as well, since it slows
the query down a bit. I left it in as it allows the semantic to be
clearly defined when there are ties.
June 28, 2009 11:30 PM
Commit by bkuhn :: r5981 /trunk/poker-network/ (8 files in 3 dirs):Merge packet-table-bug-13771 into trunk: PacketPokerTable.reason implementation...Merge packet-table-bug-13771 into trunk: PacketPokerTable.reason implementation See packet-table-bug-13771 commit logs from r5960 to r5967 for detailed implementation notes. Closes bug#13771. A summary of the work follows: * PacketPokerTable.reason is now included. It defaults to an empty string, but (when possible) the server sets this string to indicate the reason the PacketPokerTable() is being sent. The documentation in pokerpackets.py list the possible reasons. * pokertable.py join and move methods need to carry along reason to facilitate packet generation. * pokeravatar.py now sends reason and argument in the proper places. * pokerservice.py must do the same in two places: tourney creation and moving a player during a tourney. * Test coverage is corrected and complete throughout.
June 28, 2009 10:35 PM
Commit by bkuhn :: r5980 /branches/table-picker-bug-13789/poker-network/ChangeLog:Added ChangeLog entry for last changeAdded ChangeLog entry for last change
June 28, 2009 09:17 PM
Commit by bkuhn :: r5979 /branches/table-picker-bug-13789/poker-network/pokernetwork/pokerservice.py:Added ORDER BY on listTables() so that the tables with the most playersAdded ORDER BY on listTables() so that the tables with the most players are...
are highest in the list. The existing code does the rest.
June 28, 2009 09:16 PM
Commit by bkuhn :: r5978 /branches/table-picker-bug-13789/poker-network/ (ChangeLog tests/test-pokeravatar.py.in):On bug#13789, wrote to two tests that should succeed once this bug isOn bug#13789, wrote to two tests that should succeed once this bug is closed but...
closed but currently fail.
June 28, 2009 09:16 PM
Commit by bkuhn :: r5977 /branches/table-picker-bug-13789/:Created branch, table-picker-bug-13789: Branched from trunk to begin work on resolving bug#13789Created branch, table-picker-bug-13789: Branched from trunk to begin work on...
June 28, 2009 08:23 PM
Commit by bkuhn :: r5976 /branches/packet-table-bug-13771/poker-network/po/ (16 files):Merged in changed po files from trunkMerged in changed po files from trunk
June 28, 2009 08:13 PM
Commit by bkuhn :: r5975 /trunk/poker-network/ (4 files in 3 dirs):Fixed bug#13772: PacketPokerTablePicker() has option, auto_blind_anteFixed bug#13772: PacketPokerTablePicker() has option, auto_blind_ante Client can...
Client can include a packet field, auto_blind_ante in
PacketPokerTablePicker() to have it act as if a
PacketPokerAutoBlindAnte() had been sent. Documentation is improved to
explain this, and while we're at it, documentation is for
PacketPokerAutoBlindAnte() and PacketPokerNoautoBlindAnte() was
improved.
June 28, 2009 08:12 PM
Commit by bkuhn :: r5974 /branches/table-picker-bug-13772/poker-network/ (19 files in 4 dirs):Merged in trunk to this branch before doing merge back into trunkMerged in trunk to this branch before doing merge back into trunk
June 28, 2009 07:40 PM
Commit by bkuhn :: r5973 /trunk/poker-network/ (20 files in 4 dirs):Merge from table-picker-bug-13787 into trunk. See table-picker-bug-13787 commit...Merge from table-picker-bug-13787 into trunk. See table-picker-bug-13787 commit logs from r5949 to r5953 for detailed implementation notes. A summary of that work follows: Closes bug#13787: PacketPokerError() sent on PacketPokerTablePickerFailure() * Deprecated empty PacketPokerTable() sent in response to PacketPokerTableJoin(). Currently, both empty PacketPokerTable() and a PacketPokerError() are sent if PacketPokerTableJoin() fails. * PacketPokerTablePicker() now only returns PacketPokerError() if it cannot find a table. It only returns a PacketPokerTable() if a table is Join()'ed. (Note: there was some debate whether we should temporarily continue to support empty-PacketPokerTable() semantics on failure, since jpoker currently expects it. Eventually, it was decided that since there are various bugs in TablePicker() right now, and that we should resolve all the critical ones and make it work in jpoker at once.) * Documentation of PacketPokerTableJoin() and PacketPokerTablePicker() behavior in pokerpackets.py is improved.
June 28, 2009 07:32 PM
Commit by bkuhn :: r5972 /branches/table-picker-bug-13787/poker-network/ (3 files in 3 dirs):Reverted last commit based on IRC discussion w/ dacharyReverted last commit based on IRC discussion w/ dachary
June 28, 2009 06:45 PM
Commit by bkuhn :: r5971 /branches/table-picker-bug-13772/poker-network/ (3 files in 3 dirs):xMerge table-picker-bug-13787 into table-picker-bug-13772 . Just keepingxMerge table-picker-bug-13787 into table-picker-bug-13772 . Just keeping...
table-picker-bug-13772 in sync with table-picker-bug-13787, since the
latter will be merged into trunk first, and they overlap files.
June 28, 2009 05:46 PM
Commit by bkuhn :: r5970 /branches/table-picker-bug-13787/poker-network/ (3 files in 3 dirs):bug#13787: proppy asks that TablePicker() continue to perform thebug#13787: proppy asks that TablePicker() continue to perform the deprecated...
deprecated behavior of sending empty PacketPokerTable() for a while so
that he can have time to change jpoker. We should be able to remove
support for the old interface very soon, since jpoker is the only client
that implements PacketPokerTablePicker().
June 28, 2009 05:42 PM
Commit by bkuhn :: r5969 /branches/packet-table-bug-13771/poker-network/ (3 files in 3 dirs):PokerService changes for bug#13771: Add tourney reasons for PacketPokerTable()PokerService changes for bug#13771: Add tourney reasons for PacketPokerTable()...
In two cases, PokerService needs causes a PacketPokerTable() to be
generated: when it starts a tourney and when it moves players to another
table in a tourney. This change corrects the tests and the code so that
the proper 'reason' field is given in those PacketPokerTable()s.
June 28, 2009 05:06 PM
Commit by bkuhn :: r5968 /branches/packet-table-bug-13771/poker-network/ (4 files in 3 dirs):Merged packet-table-bug-13771 into table-picker-bug-13772.Merged packet-table-bug-13771 into table-picker-bug-13772. Loic reviewed and...
Loic reviewed and approved table-picker-bug-13772, and therefore I expect
that branch will be merged back to trunk before packet-table-bug-13771
will be, and therefore I should have those changes here to make later
merging easy.
June 28, 2009 04:41 PM
Commit by bkuhn :: r5967 /branches/packet-table-bug-13771/poker-network/ (4 files in 3 dirs):bug#13771: Implementation of PacketPokerTable.reason throughout pokeravatar.py.bug#13771: Implementation of PacketPokerTable.reason throughout pokeravatar.py....
Also, added reason field implementation in pokerpackets.py, which was not
added in previous work on this branch.
Finally, a few changes to tests to cover the changes made in pokeravatar.py
June 28, 2009 04:38 PM
Commit by bkuhn :: r5966 /branches/packet-table-bug-13771/poker-network/ (4 files in 3 dirs):Basic implementation in pokertable for bug#13771. Corrected all tests,Basic implementation in pokertable for bug#13771. Corrected all tests, and they...
and they are now passing, and reason argument is added to all
join()/joinTable() calls.
June 28, 2009 04:37 PM
Commit by bkuhn :: r5965 /branches/packet-table-bug-13771/poker-network/ (ChangeLog tests/test-pokertable.py.in):Forgot to update createPlayer in Transient tests as well in previous commit.Forgot to update createPlayer in Transient tests as well in previous commit.
June 28, 2009 04:37 PM
Commit by bkuhn :: r5964 /branches/packet-table-bug-13771/poker-network/ (3 files in 3 dirs):Work toward bug#13771: Test coverage in pokertable for new reason argument.Work toward bug#13771: Test coverage in pokertable for new reason argument.
June 28, 2009 03:19 PM
Commit by bkuhn :: r5963 /branches/packet-table-bug-13771/poker-network/ (4 files in 3 dirs):Merged table-picker-bug-13787 branch into packet-table-bug-13771 Loic approved...Merged table-picker-bug-13787 branch into packet-table-bug-13771 Loic approved the patch for table-picker-bug-13787 on the pokersource-users email list: https://mail.gna.org/public/pokersource-users/2009-06/msg00040.html Therefore, I expect that branch will be merged into trunk before this one, and I expected I'd be generating more conflicts here from that branch as I continued working.
June 28, 2009 02:56 PM
Commit by bkuhn :: r5962 /branches/packet-table-bug-13771/poker-network/ (3 files in 3 dirs):Began tests that will exhibit bug#13771, expecting PacketPokerTable() toBegan tests that will exhibit bug#13771, expecting PacketPokerTable() to be...
be tagged with a 'reason'. I also added the reason codes to
PacketPokerTable() as constants.
June 28, 2009 02:48 PM
Commit by bkuhn :: r5961 /branches/packet-table-bug-13771/poker-network/ (ChangeLog pokernetwork/pokerpackets.py):Beginning bug#13771: Documented and added reason field for PacketPokerTable()Beginning bug#13771: Documented and added reason field for PacketPokerTable()
June 28, 2009 02:33 AM
Commit by bkuhn :: r5960 /branches/packet-table-bug-13771/:Created branch, packet-table-bug-13771: Began work on bug#13771Created branch, packet-table-bug-13771: Began work on bug#13771
June 28, 2009 02:12 AM
Commit by bkuhn :: r5959 /branches/table-picker-bug-13772/poker-network/ (3 files in 3 dirs):Toward completion of bug#13772: Impelmentation of auto_blind_ante optionToward completion of bug#13772: Impelmentation of auto_blind_ante option This...
This two line change implements the feature in pokeravatar.py.
June 28, 2009 01:41 AM
Commit by bkuhn :: r5958 /branches/table-picker-bug-13772/poker-network/ (3 files in 3 dirs):Changed tests so they exhibit behavior for bug#13772Changed tests so they exhibit behavior for bug#13772 Documentation of...
Documentation of PacketPokerTablePicker() auto_blind_ante field.
Improved documentation for PacketPokerAutoBlindAnte() and PacketPokerNoautoBlindAnte().
June 28, 2009 01:31 AM
Commit by bkuhn :: r5957 /branches/table-picker-bug-13772/poker-network/ (ChangeLog pokernetwork/pokerpackets.py):Began work on bug#13772: Added new boolean field toBegan work on bug#13772: Added new boolean field to PacketPokerTablePicker,...
PacketPokerTablePicker, auto_blind_ante
June 28, 2009 01:31 AM
Commit by bkuhn :: r5956 /branches/table-picker-bug-13772/:Created branch, table-picker-bug-13772: Branched from completed work on table-picker-bug-13787 branch to begin work on closing bug#13772Created branch, table-picker-bug-13772: Branched from completed work on...
June 28, 2009 12:59 AM
Commit by bkuhn :: r5955 /branches/table-picker-bug-13787/table-picker-bug-13787/:Removed accidental svn operation that copied a whole branch incorrectlyRemoved accidental svn operation that copied a whole branch incorrectly
June 28, 2009 12:52 AM
Commit by bkuhn :: r5954 /branches/table-picker-bug-13787/table-picker-bug-13787/:Created branch, table-picker-bug-13787: table-picker-bug-13772Created branch, table-picker-bug-13787: table-picker-bug-13772
June 28, 2009 12:49 AM
Commit by bkuhn :: r5953 /branches/table-picker-bug-13787/poker-network/ (ChangeLog tests/test-pokeravatar.py.in):Full test coverage was lost by last committed. Added one additional test in avatar to cover new lineFull test coverage was lost by last committed. Added one additional test in...
June 28, 2009 12:27 AMJune 27, 2009 Pokersource
Commit by bkuhn :: r5952 /branches/table-picker-bug-13787/poker-network/ (4 files in 3 dirs):For bug#13787, implement Join() returns Error() idea: * changed TablePicker() to...For bug#13787, implement Join() returns Error() idea: * changed TablePicker() to return only PokerPacketError() * changed TableJoin() to return both PokerPacketError() and empty PokerTable() * related changes to tests as well.
June 27, 2009 07:40 PM
Commit by bkuhn :: r5951 /branches/table-picker-bug-13787/poker-network/ (3 files in 3 dirs):Documentation improvements, toward bug#13787: * Deprecated PacketPokerTable()...Documentation improvements, toward bug#13787: * Deprecated PacketPokerTable() empty for PacketPokerTableJoin(), added documentation of the error packet for it, and generally improved Join()'s documentation. * Changed error condition for TablePicker() to be *just* the error packet. * s/UNKNOWN_FAILURE/GENERAL_FAILURE/: seems like a better name.
June 27, 2009 06:43 PM
Commit by bkuhn :: r5950 /branches/table-picker-bug-13787/poker-network/ (3 files in 3 dirs):Beginning work on bug#13787: test cover for new error packet on TABLE_PICKER.Beginning work on bug#13787: test cover for new error packet on TABLE_PICKER....
Also added an error code for it in the TableJoin() packet.
June 27, 2009 06:11 PM
Commit by bkuhn :: r5949 /branches/table-picker-bug-13787/:Created branch, table-picker-bug-13787Created branch, table-picker-bug-13787
June 27, 2009 05:44 PM
Commit by bkuhn :: r5948 /branches/table-picker/ (22 files in 12 dirs):Merged trunk into table-picker branch so that I can use table-pickerMerged trunk into table-picker branch so that I can use table-picker branch...
branch again for closing a few bugs in trunk with the table-picker.
June 27, 2009 04:00 PMJune 26, 2009 Pokersource
Commit by loic :: r5947 /tags/poker_network_1_7_5_1/poker-network/:poker_network_1_7_5_1poker_network_1_7_5_1
June 26, 2009 11:17 AM
Commit by loic :: r5946 /tags/poker_network_1_7_5_1/:poker_network_1_7_5_1poker_network_1_7_5_1
June 26, 2009 11:17 AM
Commit by loic :: r5945 /tags/poker_network_1_7_5_1/:invalid poker_network_1_7_5_1invalid poker_network_1_7_5_1
June 26, 2009 11:17 AM
Commit by loic :: r5944 /trunk/poker-network/ChangeLog:*** empty log message ****** empty log message ***
June 26, 2009 10:29 AM
Commit by loic :: r5943 /trunk/poker-network/ (2 files in 2 dirs):Fixes https://gna.org/bugs/index.php?13769Fixes https://gna.org/bugs/index.php?13769 user A is disconnected, tourney T...
user A is disconnected, tourney T finishes, user A connects ( because tourney T is finished, it will now be added to user A tourneys list ), doTourneyDeleteRoute runs (was scheduled to run after a delay)
June 26, 2009 10:24 AM
Commit by loic :: r5942 /tags/poker_network_1_7_5_1/poker-network/:poker_network_1_7_5_1poker_network_1_7_5_1
June 26, 2009 09:27 AM
Commit by loic :: r5941 /tags/poker_network_1_7_5_1/:poker_network_1_7_5_1poker_network_1_7_5_1
June 26, 2009 09:27 AM
Commit by loic :: r5940 /tags/poker_network_1_7_5_1/:invalid poker_network_1_7_5_1invalid poker_network_1_7_5_1
June 26, 2009 09:27 AM
Commit by loic :: r5939 /trunk/poker-network/debian/ (2 files):Fixes https://gna.org/bugs/?13765Fixes https://gna.org/bugs/?13765 poker-network debian installation/upgrade...
poker-network debian installation/upgrade delete poker.server.xml
June 26, 2009 08:45 AMJune 24, 2009 Pokersource
Commit by loic :: r5938 /tags/poker_network_1_7_5_1/poker-network/:poker_network_1_7_5_1poker_network_1_7_5_1
June 24, 2009 06:07 AM
Commit by loic :: r5937 /tags/poker_network_1_7_5_1/:poker_network_1_7_5_1poker_network_1_7_5_1
June 24, 2009 06:07 AM
Commit by loic :: r5936 /tags/poker_network_1_7_5_1/:invalid poker_network_1_7_5_1invalid poker_network_1_7_5_1
June 24, 2009 06:07 AMJune 23, 2009 Pokersource
Commit by bkuhn :: r5935 /trunk/poker-network/ (9 files in 4 dirs):Implementation of PacketPokerTablePicker(), merged from table-picker branch....Implementation of PacketPokerTablePicker(), merged from table-picker branch. Detailed implementation logs are in table-picker branch, r5830 to r5933. The commit message below contains a summary of the feature implementation details. The feature itself is best documented in the "Semantics" section for the PacketPokerTablePicker() (in pokerpackets.py). This merge closes sr#2364. Implementation Details: * Expanded the method PokerService.listTables() to include various additional criteria needed to find a list of tables that matched the desired parameters sought by the requesting player. Additional indexes were added on dbtable, pokertables, to speed this up. * PokerService.getTableBestByCriteria() uses the aforementioned new listTables(). getTableBestByCriteria() loops through the tables returned by listTables(). It eliminates tables that: + are full, or + have too many players sitting out, such that the requested minimum player count would (effectively) not be reached, or + have minimum buy-ins such that the requesting player could not afford to play. * Refactored PokerAvatar.handlePacketLogic() somewhat to create a variety of so-called "perform" functions. These functions move some of the code that was originally in-line inside the giant "if" statement into their own methods. * PokerAvatar.performPacketPokerTablePicker() takes advantage of the aforementioned "perform" functions to ensure its sequence of automatic packet operations work exactly as if the client had sent those very packets itself. * Added a helper function for constructing a string ready for PokerService.listTables() in PokerAvatar. Tests Implementation Details: * Created PokerAvatarTestCaseBaseClass so additional client/server test case classes can be created to reuse some of the methods from the original PokerAvatarTestCase. * Various feature-oriented tests are in PokerAvatarTablePickerTestCase, which also serves as unit test coverage for handlePacketLogic(). * Standard unit test coverage for the new listTables() and for getTableBestByCriteria() is provided. Future Work: During implementation, the idea came up that table selection by the TablePicker should help keep the cash game tables site-wide as balanced as possible, which is the inspiration for sr#2368 and for the currently-skipped test04_tablePicker_twoPossibleGivesMostEmpty
June 23, 2009 02:54 AM
Commit by bkuhn :: r5934 /branches/table-picker/poker-network/tests/test-pokeravatar.py.in:Oops. A few test classes were commented out by last commitOops. A few test classes were commented out by last commit
June 23, 2009 02:39 AM
Commit by bkuhn :: r5933 /branches/table-picker/poker-network/ (ChangeLog tests/test-pokeravatar.py.in):On additional test for sitOut situation: no tables found by picker due to all sit-outsOn additional test for sitOut situation: no tables found by picker due to all...
June 23, 2009 02:20 AM
Commit by bkuhn :: r5932 /branches/table-picker/poker-network/tests/test-pokeravatar.py.in:Various fixes to the TablePicker() tests: * timeout of 540 is needed as some of...Various fixes to the TablePicker() tests: * timeout of 540 is needed as some of the later tests take quite a long time. * fail if setMoney is given an odd setting. * Skip test04_tablePicker_twoPossibleGivesMostEmpty for now. sr#2368 has been created for whenever someone implements this feature. * Other tests needed minor fixes to work properly.
June 23, 2009 02:15 AM
Commit by bkuhn :: r5931 /branches/table-picker/poker-network/ (3 files in 3 dirs):getTableBestByCriteria() now skips consideration of tables that havegetTableBestByCriteria() now skips consideration of tables that have enough...
enough people sitting out such that user min_players criterion is not met.
Additional test also provided.
June 23, 2009 01:33 AM
Commit by bkuhn :: r5930 /branches/table-picker/poker-network/ (ChangeLog tests/test-pokerservice.py.in):Additional tests to cover new getTableBestByCriteria() functionality,Additional tests to cover new getTableBestByCriteria() functionality, which will...
which will prevent returning tables that have to many players sitting out.
June 23, 2009 01:32 AM
Commit by bkuhn :: r5929 /branches/table-picker/poker-network/ (ChangeLog pokernetwork/pokerservice.py):Added order by serial to query for listTables() so that lower numbered tables are always first on the listAdded order by serial to query for listTables() so that lower numbered tables...
June 23, 2009 01:32 AM
Commit by bkuhn :: r5928 /branches/table-picker/poker-network/ (ChangeLog pokernetwork/pokerpackets.py):(via proppy) Improved documentation on PacketPokerTablePicker() semantics.(via proppy) Improved documentation on PacketPokerTablePicker() semantics.
June 23, 2009 01:32 AM